root/Jyotisha
1
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(rectification): unblock next build typecheck for house tables

Browse Source 
Docker npm run build failed on Failed to type check. The skill-package-registry Import traces were only file-tracing noise; houseTable used && on string|null, and eight-method tests compared impossible literals that tsconfig still typechecks.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Jesse_Chen
2026-08-20 12:21:08 +08:00
parent 3c6c86e307
commit 0eebf9713f
3 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/rectification-candidate-result.ts
+2 -2
View File
@@ -220,8 +220,8 @@ export function parseRectificationCandidateResult(value: unknown): Rectification
const fallbackHouseTable = parseRectificationHouseTable(snapshot.houseTable)
?? parseRectificationHouseTable(snapshot.house_table)
?? parseRectificationHouseTable(receipt?.house_table);
const houseTable = (selectedTime && houseTablesByTime[selectedTime])
?? (representativeTime && houseTablesByTime[representativeTime])
const houseTable = (selectedTime ? houseTablesByTime[selectedTime] : null)
?? (representativeTime ? houseTablesByTime[representativeTime] : null)
?? fallbackHouseTable;
return {
frontend/tests/rectification-eight-method.test.ts
+9 -4
View File
@@ -221,8 +221,7 @@ test("declined relationship skips to career and still skips horary", () => {
});
assert.equal(plan.next_followup?.method_id, "d10_career");
assert.equal(plan.next_followup?.domain, "career");
assert.equal(plan.do_not_poll.includes("horary"), true);
assert.equal(plan.do_not_poll.includes("appearance"), false);
assert.deepEqual([...plan.do_not_poll], ["horary"]);
});
test("D9 differ becomes an internal ask theme without sign labels", () => {
@@ -305,7 +304,10 @@ test("D24-only window change folds into education follow-up without a second lay
const observations = internalObservationsFromWindowScan(scan);
assert.equal(observations.find((item) => item.layer === "d5")?.candidates_differ, true);
assert.equal(observations.find((item) => item.layer === "d5")?.ask_theme, "education_style");
assert.equal(observations.some((item) => item.layer === "d24"), false);
assert.deepEqual(
observations.map((item) => item.layer),
["d9", "d10", "d4", "d5", "d7", "d12", "d11", "d30"],
);
const plan = buildMethodFollowupPlan({
evidence: [
{ status: "confirmed", domain: "relationship", datePrecision: "year", occurredFrom: "2018-01-01", occurredTo: null },
@@ -353,7 +355,10 @@ test("D11-only window change folds into finance follow-up without delaying adopt
assert.equal(observations.find((item) => item.layer === "d11")?.candidates_differ, true);
assert.equal(observations.find((item) => item.layer === "d11")?.ask_theme, "finance_change");
assert.equal(observations.find((item) => item.layer === "d30")?.ask_theme, "health_pressure");
assert.equal(observations.some((item) => item.layer === "d2"), false);
assert.deepEqual(
observations.map((item) => item.layer),
["d9", "d10", "d4", "d5", "d7", "d12", "d11", "d30"],
);
const plan = buildMethodFollowupPlan({
evidence: [
{ status: "confirmed", domain: "relationship", datePrecision: "year", occurredFrom: "2018-01-01", occurredTo: null },