root/Jyotisha
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: align conversational persistence validators

Browse Source
This commit is contained in:
Jesse_Chen
2026-07-20 23:42:37 +08:00
parent c883c401aa
commit ae41023b96
6 changed files with 485 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_conversational_rectification_contract.py
+74 -2
View File
@@ -47,8 +47,8 @@ def test_v3_schema_is_account_scoped_bounded_and_service_role_only() -> None:
)
assert "primary key (case_id, turn_version)" in sql
assert "char_length(narrative) between 1 and 12000" in sql
assert "char_length(raw_text) between 1 and 4000" in sql
assert "conversational_rectification_text_utf16_length(narrative) between 1 and 12000" in sql
assert "conversational_rectification_text_utf16_length(raw_text) between 1 and 4000" in sql
assert "date_precision in ('day', 'month', 'year', 'range', 'unknown')" in sql
assert "extraction_status in ('clear', 'needs_clarification', 'corrected')" in sql
assert "primary key (case_id, action_id)" in sql
@@ -310,6 +310,13 @@ def test_durable_json_numbers_and_evidence_recap_share_postgres_bounds() -> None
sql = _normalized(SCHEMA)
assert "create or replace function public.conversational_rectification_numbers_are_stable" in sql
numeric = _function(sql, "conversational_rectification_numbers_are_stable")
for invariant in (
"abs(v_number) <= 9007199254740991",
"abs(v_number) between 0.000001 and 1000000",
"v_number = pg_catalog.trunc(v_number, 6)",
):
assert invariant in numeric
for validator in (
"conversational_rectification_valid_declared_birth_input",
"conversational_rectification_valid_private_candidate",
@@ -322,6 +329,71 @@ def test_durable_json_numbers_and_evidence_recap_share_postgres_bounds() -> None
assert "octet_length(p_value::text) <= 24576" in recap
def test_sql_json_strings_and_enum_arrays_reject_null_and_non_string_values() -> None:
sql = _normalized(SCHEMA)
assert "jsonb_array_elements_text" not in sql
candidate = _function(sql, "conversational_rectification_valid_candidate")
assert "jsonb_typeof(p_value -> 'status') is distinct from 'string'" in candidate
request = _function(sql, "conversational_rectification_valid_evidence_request")
assert "jsonb_typeof(p_value -> 'dateprecision') = 'string'" in request
assert "jsonb_array_elements(p_value -> 'domains')" in request
assert "jsonb_typeof(domain) is distinct from 'string'" in request
actions = _function(sql, "conversational_rectification_valid_actions")
assert "jsonb_array_elements(p_value)" in actions
assert "jsonb_typeof(action) is distinct from 'string'" in actions
private = _function(sql, "conversational_rectification_valid_private_candidate")
assert "jsonb_array_elements(p_value -> 'suggesteddomains')" in private
assert "jsonb_typeof(domain) is distinct from 'string'" in private
public_turn = _function(sql, "conversational_rectification_valid_public_turn")
for key in ("caseid", "journeyprotocol", "status"):
assert f"jsonb_typeof(p_value -> '{key}') = 'string'" in public_turn
def test_sql_uuid_text_matches_zod_canonical_hyphenated_syntax_at_all_json_boundaries() -> None:
sql = _normalized(SCHEMA)
uuid = _function(sql, "conversational_rectification_valid_uuid_text")
assert "^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$" in uuid
assert "perform p_value::uuid" in uuid
for validator in (
"conversational_rectification_valid_evidence_recap",
"conversational_rectification_valid_life_event_evidence",
"conversational_rectification_valid_private_candidate",
"conversational_rectification_valid_public_turn",
"conversational_rectification_valid_action_request",
"conversational_rectification_valid_action_response",
):
assert "conversational_rectification_valid_uuid_text" in _function(sql, validator)
def test_sql_nonblank_and_maximum_text_rules_match_ecmascript_and_utf16() -> None:
sql = _normalized(SCHEMA)
assert "create or replace function public.conversational_rectification_text_utf16_length" in sql
for validator, minimum_nonblank_calls, minimum_utf16_calls in (
("conversational_rectification_text_array_is_bounded", 1, 1),
("conversational_rectification_valid_technical_receipt", 1, 1),
("conversational_rectification_valid_evidence_recap", 2, 2),
("conversational_rectification_valid_validation_receipt", 2, 3),
("conversational_rectification_valid_life_event_evidence", 3, 3),
("conversational_rectification_valid_private_candidate", 2, 2),
("conversational_rectification_valid_declared_birth_input", 2, 2),
("conversational_rectification_valid_public_turn", 2, 2),
("conversational_rectification_valid_action_response", 2, 2),
):
body = _function(sql, validator)
assert body.count("conversational_rectification_text_is_nonblank") >= minimum_nonblank_calls
assert body.count("conversational_rectification_text_utf16_length") >= minimum_utf16_calls
for durable_column in ("narrative", "raw_text", "event_summary", "date_value"):
assert f"conversational_rectification_text_utf16_length({durable_column})" in sql
def test_life_event_evidence_is_strictly_validated_before_insert() -> None:
schema = _normalized(SCHEMA)
transitions = _normalized(TRANSITIONS)
tests/test_conversational_rectification_postgres_runtime.py
+122 -1
View File
@@ -638,6 +638,7 @@ def test_postgres_uses_the_shared_stable_numeric_boundary_vectors(
stable_vector = {
"zero": 0,
"minFraction": 0.000001,
"ieeeRoundingBoundary": 1.000001,
"decimal": 0.123456,
"maxSafe": 9_007_199_254_740_991,
}
@@ -649,11 +650,14 @@ def test_postgres_uses_the_shared_stable_numeric_boundary_vectors(
)::text;
"""
)
assert json.loads(numeric_result) == {"valid": True, "bytes": 86}
assert json.loads(numeric_result) == {"valid": True, "bytes": 120}
for invalid in (
{"nested": [{"score": 1e-7}]},
{"nested": [{"score": 1e-100}]},
{"nested": [{"score": 0.0000012}]},
{"nested": [{"score": 0.1234567}]},
{"nested": [{"score": 1_000_000.000001}]},
{"nested": [{"score": 9_007_199_254_740_992}]},
):
assert pg14_database.sql(
@@ -678,6 +682,123 @@ def test_postgres_uses_the_shared_stable_numeric_boundary_vectors(
) == "false"
def test_json_text_validators_align_types_uuid_unicode_and_utf16(
pg14_database: PgDatabase,
) -> None:
case_id = "00000000-0000-4000-8000-000000000960"
turn = _valid_turn(case_id)
private_candidate = _valid_private_candidate()
unicode_whitespace = "\u00a0\u2007\ufeff"
canonical_uuid = "a9890e09-d535-46f0-9a36-86017515a5a1"
compact_uuid = canonical_uuid.replace("-", "")
uuid_result = json.loads(pg14_database.sql(
f"""
select pg_catalog.jsonb_build_object(
'lower', public.conversational_rectification_valid_uuid_text({_text(canonical_uuid)}),
'upper', public.conversational_rectification_valid_uuid_text({_text(canonical_uuid.upper())}),
'compact', public.conversational_rectification_valid_uuid_text({_text(compact_uuid)}),
'braced', public.conversational_rectification_valid_uuid_text({_text('{' + canonical_uuid + '}')})
)::text;
"""
))
assert uuid_result == {"lower": True, "upper": True, "compact": False, "braced": False}
invalid_turns = (
{**turn, "candidate": {**turn["candidate"], "status": None}},
{
**turn,
"technicalReceipt": {**turn["technicalReceipt"], "stableLayers": [None]},
},
{
**turn,
"technicalReceipt": {**turn["technicalReceipt"], "sensitiveLayers": [42]},
},
{
**turn,
"evidenceRequest": {**turn["evidenceRequest"], "domains": ["career", None]},
},
{
**turn,
"evidenceRequest": {**turn["evidenceRequest"], "datePrecision": None},
},
{**turn, "actions": [None]},
{**turn, "status": None},
{**turn, "narrative": unicode_whitespace},
{
**turn,
"evidenceRecap": [{
"id": compact_uuid,
"summary": "summary",
"dateLabel": "2020-01",
}],
},
)
for invalid in invalid_turns:
assert pg14_database.sql(
"select public.conversational_rectification_valid_public_turn("
f"{_jsonb(invalid)})::text"
) == "false"
invalid_private_candidates = (
{**private_candidate, "resultId": compact_uuid},
{**private_candidate, "suggestedDomains": ["career", None]},
{**private_candidate, "d1Stability": None},
{**private_candidate, "calculationVersion": unicode_whitespace},
{
**private_candidate,
"workingState": {"phase": "initial", "iteration": 0, "notes": [unicode_whitespace]},
},
{
**private_candidate,
"futureWindows": [{
"label": unicode_whitespace,
"startDate": "2020-01-01",
"endDate": "2020-01-02",
"scoreable": False,
}],
},
)
for invalid in invalid_private_candidates:
assert pg14_database.sql(
"select public.conversational_rectification_valid_private_candidate("
f"{_jsonb(invalid)})::text"
) == "false"
invalid_declared = {
**_valid_declared_birth_input(),
"birthTimeClue": unicode_whitespace,
"birthplace": {
**_valid_declared_birth_input()["birthplace"],
"city": unicode_whitespace,
},
}
assert pg14_database.sql(
"select public.conversational_rectification_valid_declared_birth_input("
f"{_jsonb(invalid_declared)})::text"
) == "false"
assert pg14_database.sql(
"select public.conversational_rectification_valid_validation_receipt("
f"{_jsonb({'modelId': unicode_whitespace, 'schemaValidated': True})})::text"
) == "false"
assert pg14_database.sql(
"select public.conversational_rectification_valid_action_response("
f"{_jsonb({'success': False, 'credits': 7, 'billing_state': None, 'error_code': unicode_whitespace})}, "
"'reserve_fee')::text"
) == "false"
assert pg14_database.sql(
"select public.conversational_rectification_text_utf16_length("
f"{_text('😀' * 40)})::text"
) == "80"
for model_id, expected in (("😀" * 60, "true"), ("😀" * 61, "false")):
assert pg14_database.sql(
"select public.conversational_rectification_valid_validation_receipt("
f"{_jsonb({'modelId': model_id, 'schemaValidated': True})})::text"
) == expected
def test_save_rejects_invalid_evidence_without_discarding_or_coercing_fields(
pg14_database: PgDatabase,
) -> None: