Jyotisha/frontend/tests/consultation-stream-recovery.test.ts

import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import test from "node:test";

const read = (path: string) => readFileSync(new URL(`../${path}`, import.meta.url), "utf8");
const consultRoute = read("src/app/api/consult/route.ts");
const statusRoute = read("src/app/api/consult/status/route.ts");
const migration = read("supabase/migrations/20260808030000_consultation_stream_recovery.sql");
const statusReadMigration = read("supabase/migrations/20260811010000_consultation_status_service_role_read.sql");

test("reserves usage and binds the owned consultation session atomically", () => {
  assert.match(migration, /add column if not exists session_id uuid references public\.chat_sessions\(id\) on delete set null/i);
  assert.match(migration, /reserve_consultation_usage\([\s\S]*p_session_id uuid[\s\S]*from public\.chat_sessions as session[\s\S]*session\.id = p_session_id[\s\S]*session\.user_id = p_user_id[\s\S]*session\.session_type = 'consultation'/i);
  assert.match(migration, /from public\.authorize_usage[\s\S]*insert into public\.consultation_requests\(user_id, request_id, session_id, status\)[\s\S]*values \(p_user_id, btrim\(p_request_id\), p_session_id, 'reserved'\)/i);
  assert.match(migration, /reserve_consultation_usage\(uuid, text, uuid, text, integer\)/i);
  assert.match(consultRoute, /rpc\("reserve_consultation_usage"[\s\S]*p_session_id: sessionId/);
  assert.doesNotMatch(consultRoute, /from\("consultation_requests"\)[\s\S]*\.update\(\{ session_id: sessionId/);
});

test("persists transformed assistant metadata before atomically settling usage", () => {
  assert.equal(consultRoute.match(/continueAfterDisconnect: true/g)?.length, 4);
  assert.equal(consultRoute.match(/onComplete: \(rawTransformedText\) => settle\(\(\) => completeResponse\(/g)?.length, 2);
  assert.match(
    consultRoute,
    /parseAgentReply\([\s\S]*?rawTransformedText,[\s\S]*?consultationTheme,[\s\S]*?createConsultationReplyMetadata\(\{ theme: consultationTheme, question: visibleQuestion \}\),[\s\S]*?\)/,
  );
  assert.match(consultRoute, /role: "assistant" as const,[\s\S]*suggestions: reply\.suggestions,[\s\S]*techniqueTruth,[\s\S]*workflowReceipt/);

  const append = migration.indexOf("set messages = session.messages || jsonb_build_array(p_response_message)");
  const store = migration.indexOf("set response_message = p_response_message");
  const settle = migration.indexOf("from public.complete_usage");
  const complete = migration.indexOf("set status = 'completed'");
  assert.ok(append >= 0 && append < store && store < settle && settle < complete);
});

test("persists partial transformed output when the upstream stream errors", () => {
  assert.doesNotMatch(consultRoute, /completeInterrupted|completeUsage\(accounting, userId, requestId/);
  assert.equal(
    consultRoute.match(/onError: \(_error, emitted, output: string\) => settleErrored\(emitted, output\)/g)?.length,
    2,
  );
  assert.equal(consultRoute.match(/const settleErrored = \(emitted: boolean, output: string\) => settle\(/g)?.length, 2);
  assert.equal(consultRoute.match(/emitted[\s\S]*?\? \(\) => completeResponse\([\s\S]*?output,[\s\S]*?result\.totalUsage,[\s\S]*?: cancel,/g)?.length, 2);
  assert.equal(consultRoute.match(/onCancel: \(\) => settle\(cancel\)/g)?.length, 2);
  assert.equal(
    consultRoute.match(/onCancel: \(\) => settleRun\(cancel, "cancelled"\)/g)?.length,
    2,
  );
});

test("Agentic failures always refund and detached execution uses a server-owned timeout", () => {
  const agentic = consultRoute.slice(
    consultRoute.indexOf("async function runAgenticConsultation("),
    consultRoute.indexOf("  try {\n    const { history } = parsed.data;"),
  );
  assert.match(agentic, /const agentAbortSignal = AbortSignal\.timeout\(110_000\)/);
  assert.equal(agentic.match(/abortSignal: agentAbortSignal/g)?.length, 2);
  assert.doesNotMatch(agentic, /abortSignal: request\.signal/);
  assert.equal(
    agentic.match(/onError: \(error\) => settleRun\(\s*cancel,[\s\S]*?toAgentObservabilityErrorCode\(error\),\s*\)/g)?.length,
    2,
  );
  const onErrorBlocks = agentic.match(/onError:[\s\S]*?onCancel:/g) ?? [];
  assert.equal(onErrorBlocks.length, 2);
  for (const block of onErrorBlocks) assert.doesNotMatch(block, /completeResponse|completed_partial/);
});

test("Agentic settlement telemetry uses the actual cancellation result", () => {
  const cancellation = consultRoute.slice(
    consultRoute.indexOf("async function cancel("),
    consultRoute.indexOf("const usageStartedAt"),
  );
  const settlement = consultRoute.slice(
    consultRoute.indexOf("let settlement:"),
    consultRoute.indexOf("const baseMessages"),
  );

  assert.match(cancellation, /return "cancelled";/);
  assert.match(cancellation, /catch \(error\) \{[\s\S]*return "failed";/);
  assert.match(settlement, /const actualSettlementResult = await settleResult\(action\)/);
  assert.match(settlement, /settlementTelemetryOutcome\(actualSettlementResult, errorCode\)/);
  assert.doesNotMatch(settlement, /logRun\(errorCode, "cancelled"\)/);
});

test("best-effort cancels a failed or uncertain durable completion before rethrowing", () => {
  const completion = consultRoute.slice(
    consultRoute.indexOf("async function completeResponse("),
    consultRoute.indexOf("let settlement:"),
  );
  assert.match(completion, /try \{[\s\S]*accounting\.rpc\("complete_consultation_response"/);
  assert.match(completion, /catch \(error\) \{[\s\S]*await cancel\(\);[\s\S]*throw error;/);
  assert.ok(completion.indexOf("await cancel();") > completion.indexOf('accounting.rpc("complete_consultation_response"'));
});

test("serializes explicit cancellation against response persistence and charging", () => {
  const cancelFunction = migration.slice(
    migration.indexOf("create or replace function public.cancel_consultation_credit"),
    migration.indexOf("create or replace function public.complete_consultation_response"),
  );
  assert.match(cancelFunction, /pg_advisory_xact_lock\(hashtextextended\(p_user_id::text \|\| ':' \|\| btrim\(p_request_id\), 0\)\)/);
  assert.match(cancelFunction, /from public\.consultation_requests[\s\S]*for update/);
  assert.match(cancelFunction, /if v_request\.status = 'completed' then[\s\S]*'request_completed'/i);
  assert.match(cancelFunction, /if v_request\.status = 'cancelled' then[\s\S]*select true/i);
  assert.match(cancelFunction, /if v_request\.status <> 'reserved' then[\s\S]*from public\.release_usage[\s\S]*set status = 'cancelled'/i);
  assert.match(cancelFunction, /grant execute on function public\.cancel_consultation_credit\(uuid, text\)[\s\S]*to service_role/);
  assert.match(migration, /if v_request\.status = 'cancelled' then[\s\S]*'request_cancelled'/i);
  assert.match(consultRoute, /cancel_consultation_credit/);
  assert.match(consultRoute, /error_code !== "request_cancelled"/);
});

test("status endpoint supports one global reserved lookup and strict bound polling", () => {
  assert.ok(statusRoute.indexOf("supabase.auth.getUser()") < statusRoute.indexOf("createAdminSupabaseClient()"));
  assert.match(statusRoute, /activeLookup = sessionIdValue === null && requestIdValue === null/);
  assert.match(statusRoute, /activeLookup[\s\S]*\.eq\("status", "reserved"\)\.order\("created_at", \{ ascending: false \}\)\.limit\(1\)/);
  assert.match(statusRoute, /\.eq\("user_id", user\.id\)[\s\S]*\.eq\("session_id", sessionId!\.data\)[\s\S]*\.eq\("request_id", requestId!\.data\)/);
  assert.match(statusRoute, /requestId: statusData\.request_id,[\s\S]*sessionId: statusData\.session_id,[\s\S]*status: statusData\.status/);
  assert.doesNotMatch(statusRoute, /String\(data\.response_message\)|responseMessage:\s*data\.response_message as string/);
});

test("status polling grants consultation request reads only to the server role", () => {
  assert.match(statusReadMigration, /grant select on table public\.consultation_requests to service_role/i);
  assert.doesNotMatch(statusReadMigration, /grant select[\s\S]*to (anon|authenticated)/i);
});

test("detached completion and cancellation use a bounded retry ceiling", () => {
  assert.match(consultRoute, /const detachedSettlementAttempts = 3/);
  assert.match(consultRoute, /ponytail: Staging MVP ceiling—without a queue\/worker/);
  assert.match(consultRoute, /for \(let attempt = 1; attempt <= detachedSettlementAttempts; attempt \+= 1\)/);
  assert.match(consultRoute, /setTimeout\(resolve, attempt \* 150\)/);
  assert.match(consultRoute, /async function cancel\(\)[\s\S]*retryDetachedSettlement\(async \(\) =>[\s\S]*rpc\("cancel_consultation_credit"/);
  assert.match(consultRoute, /async function completeResponse\([\s\S]*retryDetachedSettlement\(async \(\) =>[\s\S]*rpc\("complete_consultation_response"/);
});

test("status expires stale reservations after fifteen minutes but leaves fresh reservations active", () => {
  assert.match(statusRoute, /const reservedLeaseMs = 15 \* 60 \* 1000/);
  assert.match(statusRoute, /ponytail: Staging MVP ceiling—without a queue\/worker/);
  assert.match(statusRoute, /Number\.isFinite\(timestamp\) && now - timestamp >= reservedLeaseMs/);
  const leaseBlock = statusRoute.slice(
    statusRoute.indexOf('if (statusData.status === "reserved" && reservationLeaseExpired(statusData.updated_at))'),
    statusRoute.indexOf("return NextResponse.json({\n    requestId: statusData.request_id"),
  );
  assert.match(leaseBlock, /runCreditRpc\([\s\S]*"cancel_consultation_credit"/);
  assert.match(leaseBlock, /\.eq\("session_id", statusData\.session_id\)[\s\S]*\.eq\("request_id", statusData\.request_id\)/);
  assert.doesNotMatch(statusRoute.slice(0, statusRoute.indexOf('if (statusData.status === "reserved"')), /cancel_consultation_credit/);
});