root/Jyotisha
2
0
Fork 0
Code Issues Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

fix(rectification): require grounded candidate claims

Browse Source
This commit is contained in:
Jesse_Chen
2026-07-31 20:56:31 +08:00
parent b0dab214b6
commit 6faa0a6be3
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/rectification-agent/director-agent.ts
+6 -4
View File
@@ -193,10 +193,12 @@ export function validateRectificationTurnPlan(input: Readonly<{ plan: unknown; d
});
const hasCapabilityGrounding = plan.publicExplanationGrounding.some((grounding) => grounding.source === "capability_matrix");
const hasObservationGrounding = plan.publicExplanationGrounding.some((grounding) => grounding.source !== "capability_matrix");
if (hasCapabilityGrounding && !hasObservationGrounding && plan.publicReply.evidenceExplanation
&& (!methodMappingPattern.test(plan.publicReply.evidenceExplanation)
|| observedResultClaimPattern.test(plan.publicReply.evidenceExplanation)
|| candidateConclusionPattern.test(plan.publicReply.evidenceExplanation))) {
const evidenceExplanation = plan.publicReply.evidenceExplanation;
if (evidenceExplanation && !hasObservationGrounding
&& (observedResultClaimPattern.test(evidenceExplanation) || candidateConclusionPattern.test(evidenceExplanation))) {
issues.push("ungrounded_candidate_claim");
}
if (hasCapabilityGrounding && !hasObservationGrounding && evidenceExplanation && !methodMappingPattern.test(evidenceExplanation)) {
issues.push("capability_claim_not_mapping");
}
if (groundedEvent && plan.publicReply.evidenceExplanation) {
frontend/tests/rectification-director.test.ts
+6 -3
View File
@@ -553,6 +553,9 @@ test("public reply allows method names but rejects private internals and ungroun
const numeric = plan({ publicReply: { acknowledgement: "这条经历已经保留。", evidenceExplanation: "D24 在候选窗内切换了 3 次。", candidateCommentary: null, limitation: null } });
assert.ok(validateRectificationTurnPlan({ plan: numeric, dossier: dossier(), latestAnswer: "", phase: "final" }).issues.includes("ungrounded_numeric_structure_claim"));
const ungroundedCandidateClaim = plan({ publicReply: { acknowledgement: "已记录。", evidenceExplanation: "D10 已经显示较早候选更符合。", candidateCommentary: null, limitation: null } });
assert.ok(validateRectificationTurnPlan({ plan: ungroundedCandidateClaim, dossier: dossier(), latestAnswer: "", phase: "final" }).issues.includes("ungrounded_candidate_claim"));
const multiple = plan({ action: { type: "ask_question", focus: { mode: "collect_independent_event", targetEventId: null, domain: null, requestedFacts: ["independent_event"], rationaleCodes: ["test"] }, question: "你记得它发生在哪一年。那时发生了什么。", optionalQuickReplies: [] } });
assert.ok(validateRectificationTurnPlan({ plan: multiple, dossier: dossier(), latestAnswer: "", phase: "final" }).issues.includes("multiple_questions"));
const single = plan({ action: { type: "ask_question", focus: { mode: "collect_independent_event", targetEventId: null, domain: null, requestedFacts: ["independent_event"], rationaleCodes: ["test"] }, question: "你还记得一件时间大致确定的重要经历吗？", optionalQuickReplies: [] } });
@@ -596,19 +599,19 @@ test("public explanations require real capability grounding for the current even
publicReply: { ...base, evidenceExplanation: "D10 已经显示这次职业变化支持较早的候选区间。" },
publicExplanationGrounding: [{ source: "capability_matrix", factKey: "domain:career" }],
});
assert.ok(validateRectificationTurnPlan({ plan: inventedResult, dossier: dossier([internship]), latestAnswer: internship.rawText, phase: "final" }).issues.includes("capability_claim_not_mapping"));
assert.ok(validateRectificationTurnPlan({ plan: inventedResult, dossier: dossier([internship]), latestAnswer: internship.rawText, phase: "final" }).issues.includes("ungrounded_candidate_claim"));
const disguisedInventedResult = plan({
publicReply: { ...base, evidenceExplanation: "这只是方法映射；D10 已经证明这次经历更符合较早出生。" },
publicExplanationGrounding: [{ source: "capability_matrix", factKey: "domain:career" }],
});
assert.ok(validateRectificationTurnPlan({ plan: disguisedInventedResult, dossier: dossier([internship]), latestAnswer: internship.rawText, phase: "final" }).issues.includes("capability_claim_not_mapping"));
assert.ok(validateRectificationTurnPlan({ plan: disguisedInventedResult, dossier: dossier([internship]), latestAnswer: internship.rawText, phase: "final" }).issues.includes("ungrounded_candidate_claim"));
const uncaughtSynonym = plan({
publicReply: { ...base, evidenceExplanation: "这只是方法映射；D10 说明该经历对应出生时段偏前。" },
publicExplanationGrounding: [{ source: "capability_matrix", factKey: "domain:career" }],
});
assert.ok(validateRectificationTurnPlan({ plan: uncaughtSynonym, dossier: dossier([internship]), latestAnswer: internship.rawText, phase: "final" }).issues.includes("capability_claim_not_mapping"));
assert.ok(validateRectificationTurnPlan({ plan: uncaughtSynonym, dossier: dossier([internship]), latestAnswer: internship.rawText, phase: "final" }).issues.includes("ungrounded_candidate_claim"));
});
test("the final plan cannot repeat a previously asked question", () => {